Merged
Conversation
cd317b3 to
3958395
Compare
When --input-xml is on and --payload-url is off to pass XML data offline, we need to set payload_url to None and continue running the DownloadVerify builder instead of returning there. Pulls in flatcar/ue-rs#93. Signed-off-by: Dongsu Park <dongsu@dpark.io>
3958395 to
1d679b0
Compare
Member
Author
|
CI passed, ready for review. |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/18976584008 |
Member
|
Maybe a changelog entry would be good with mentioning that this only affected an Alpha release (Should be backported to the current Alpha branch) |
Member
Author
|
Added changelog. |
pothos
reviewed
Oct 31, 2025
2bb6b5b to
786c861
Compare
pothos
approved these changes
Oct 31, 2025
pothos
reviewed
Oct 31, 2025
Signed-off-by: Dongsu Park <dongsu@dpark.io>
786c861 to
e302502
Compare
Member
Author
|
cherry-picked to flatcar-4487 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --input-xml is on and --payload-url is off to pass XML data offline, we need to set payload_url to None and continue running the DownloadVerify builder instead of returning there.
Also fix bugs when parsing xml tags, and bring back support for base64 hash.
Pulls in flatcar/ue-rs#93.
Testing done
CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/6888/cldsv/ passed
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.