build_library/qemu_template.sh: Make it use bash#2848
Merged
Conversation
Insisting on just sh is pointless. Use bash, so the checkbashisms script running somewhere will just shut up.
chewi
requested changes
Apr 24, 2025
Contributor
chewi
left a comment
There was a problem hiding this comment.
CI will still fail because vm_image_util.sh calls checkbashisms.
Member
sayanchowdhury
left a comment
There was a problem hiding this comment.
there is a explicit check for checkbashisms in build_library/vm_image_util.sh -- this would still fail.
The check for that script was the only consumer. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
9768a1f to
2f58762
Compare
sayanchowdhury
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insisting on just sh is pointless. Use bash, so the checkbashisms script running somewhere will just shut up.