build_library: Fix path handling in QEMU launcher script#2808
Merged
Conversation
I couldn't take it anymore! The launcher script could not handle paths outside the script's own directory, and it was driving me crazy. Now only the default values are relative to the script's directory. Given paths are relative to the current directory and absolute paths work as you would expect. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
sayanchowdhury
approved these changes
Apr 8, 2025
krnowak
reviewed
Apr 8, 2025
Member
krnowak
left a comment
There was a problem hiding this comment.
Looks like the SCRIPT_DIR variable is now unused, so maybe you could drop it.
Contributor
Author
No, it is still used, just in a different way now. |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/14333886296 |
Member
Oh, ok. I just did a search for SCRIPT_DIR in the script and the only occurence was in the third line. But maybe the script is being too clever somewhere. Anyway, looks good. |
krnowak
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_library: Fix path handling in QEMU launcher script
I couldn't take it anymore! The launcher script could not handle paths outside the script's own directory, and it was driving me crazy. Now only the default values are relative to the script's directory. Given paths are relative to the current directory and absolute paths work as you would expect.
How to use
You don't need to grab any new images, just the .sh files from bincache.
Testing done
I ran CI but without the tests because they don't use this script. I grabbed the new .sh files, compared them against the old ones, and tried them out with different paths.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.