Skip to content

image_to_vm: add support for hyperv_vhdx format#1791

Merged
ader1990 merged 1 commit intomainfrom
ader1990/hyperv-vhdx-support
Apr 9, 2024
Merged

image_to_vm: add support for hyperv_vhdx format#1791
ader1990 merged 1 commit intomainfrom
ader1990/hyperv-vhdx-support

Conversation

@ader1990
Copy link
Copy Markdown
Contributor

@ader1990 ader1990 commented Mar 25, 2024 •
edited
Loading

Add support for Gen 2 Hyper-V VMs.

See: flatcar/Flatcar#1009

./image_to_vm tool has now a new supported format: hyperv_vhdx, that produces .vhdx dynamic disks.

How to use

 ./image_to_vm.sh --from ../build/images/amd64-usr/developer-latest/ --format hyperv_vhdx

Testing done

[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

pothos
pothos reviewed Mar 25, 2024
View reviewed changes
@ader1990 ader1990 force-pushed the ader1990/hyperv-vhdx-support branch from 1f98104 to 7264cc9 Compare March 25, 2024 16:00
@ader1990 ader1990 changed the title image_to_vm: add support for hyper-v vhdx format image_to_vm: add support for hyperv_vhdx format Mar 25, 2024
@jepio
Copy link
Copy Markdown
Member

jepio commented Mar 26, 2024

Images have been produced: https://bincache.flatcar-linux.net/images/amd64/3916.0.0+vhdx/.

I don't like that the images end up being called flatcar_production_hyperv_vhdx_image.vhdx.bz2 (double vhdx).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2024 •
edited
Loading

Build action triggered: https://github.com/flatcar/scripts/actions/runs/8564352706

@ader1990
Copy link
Copy Markdown
Contributor Author

ader1990 commented Mar 26, 2024

Images have been produced: https://bincache.flatcar-linux.net/images/amd64/3916.0.0+vhdx/.

I don't like that the images end up being called flatcar_production_hyperv_vhdx_image.vhdx.bz2 (double vhdx).

It is the same naming convention for rackspace and cloudstack. Adding gen2 in the naming would be wrong, and only multiplexing the hyperv image format to create two images .vhd and .vhdx would make sense, but then, it will break the convention I saw in the current implementation, to create only one image file per format.

@ader1990
Copy link
Copy Markdown
Contributor Author

ader1990 commented Mar 26, 2024

Images have been produced: https://bincache.flatcar-linux.net/images/amd64/3916.0.0+vhdx/.

I don't like that the images end up being called flatcar_production_hyperv_vhdx_image.vhdx.bz2 (double vhdx).

@jepio I tested the image on a gen 2 vm, and the image does not properly boot with the initrd stage error: hv_utils kernel module not found. Investigation required.

@ader1990
Copy link
Copy Markdown
Contributor Author

ader1990 commented Mar 26, 2024

Images have been produced: https://bincache.flatcar-linux.net/images/amd64/3916.0.0+vhdx/.
I don't like that the images end up being called flatcar_production_hyperv_vhdx_image.vhdx.bz2 (double vhdx).

@jepio I tested the image on a gen 2 vm, and the image does not properly boot with the initrd stage error: hv_utils kernel module not found. Investigation required.

Code is failing here: https://github.com/coreos/ignition/blob/v2.18.0/internal/providers/hyperv/kvp.go#L50.
Flatcar kernel is built with hv_utils kernel module, but the module is not present in the /lib/module. Do you know why this happens?

@jepio @pothos

@ader1990
Copy link
Copy Markdown
Contributor Author

ader1990 commented Mar 26, 2024

Images have been produced: https://bincache.flatcar-linux.net/images/amd64/3916.0.0+vhdx/.
I don't like that the images end up being called flatcar_production_hyperv_vhdx_image.vhdx.bz2 (double vhdx).

@jepio I tested the image on a gen 2 vm, and the image does not properly boot with the initrd stage error: hv_utils kernel module not found. Investigation required.

Code is failing here: https://github.com/coreos/ignition/blob/v2.18.0/internal/providers/hyperv/kvp.go#L50. Flatcar kernel is built with hv_utils kernel module, but the module is not present in the /lib/module. Do you know why this happens?

@jepio @pothos

Okay, I think I know why, because we are not using the upstream initrd generation for ignition, https://github.com/coreos/ignition/blob/d304850c3d3696822bc05e0833ee4b27df9d7a38/dracut/30ignition/module-setup.sh.

This PR requires a bootengine PR to add that module.

@ader1990 ader1990 force-pushed the ader1990/hyperv-vhdx-support branch from 1076fc9 to 5026f47 Compare March 26, 2024 15:15
@ader1990 ader1990 force-pushed the ader1990/hyperv-vhdx-support branch from 5026f47 to 90ff90e Compare March 26, 2024 17:59
@ader1990 ader1990 marked this pull request as ready for review March 26, 2024 17:59
@ader1990 ader1990 requested a review from jepio March 26, 2024 17:59
@ader1990
Copy link
Copy Markdown
Contributor Author

ader1990 commented Mar 26, 2024

Test results look good, bootengine PR was merged with commit id updated, changelog was added.

@ader1990
Copy link
Copy Markdown
Contributor Author

ader1990 commented Mar 26, 2024

Note that the VHDX image file after decompression has 1.1GB in file size.

@ader1990 ader1990 force-pushed the ader1990/hyperv-vhdx-support branch from 90ff90e to 3e924bc Compare March 26, 2024 18:24
@ader1990 ader1990 mentioned this pull request Mar 27, 2024
Closed
@ader1990 ader1990 requested a review from pothos March 27, 2024 09:04
@ader1990 ader1990 force-pushed the ader1990/hyperv-vhdx-support branch from 3e924bc to 6211142 Compare March 27, 2024 10:07
@ader1990 ader1990 force-pushed the ader1990/hyperv-vhdx-support branch from 6211142 to 5261eb6 Compare March 27, 2024 10:07
@ader1990
Copy link
Copy Markdown
Contributor Author

ader1990 commented Mar 27, 2024

Bootengine commit was removed, as the flatcar/scripts main is already using the newest bootengine HEAD.

@pothos
Copy link
Copy Markdown
Member

pothos commented Mar 27, 2024

Bootengine commit was removed, as the flatcar/scripts main is already using the newest bootengine HEAD.

Almost^^ I had to push a fix as it was the repo's HEAD.

@ader1990
Copy link
Copy Markdown
Contributor Author

ader1990 commented Mar 27, 2024

Bootengine commit was removed, as the flatcar/scripts main is already using the newest bootengine HEAD.

Almost^^ I had to push a fix as it was the repo's HEAD.

I ll have to rebase on f04ba66, thought the commit was already in at that moment.

@ader1990 ader1990 force-pushed the ader1990/hyperv-vhdx-support branch from 5261eb6 to 872ad17 Compare March 27, 2024 11:03
@pothos
Copy link
Copy Markdown
Member

pothos commented Apr 5, 2024

A new build is running (.11) and should show up under https://bincache.flatcar-linux.net/images/amd64/9999.9.11+ader1990-hyperv-vhdx-support/

@ader1990 ader1990 requested a review from pothos April 8, 2024 17:16
@ader1990 ader1990 force-pushed the ader1990/hyperv-vhdx-support branch from b101201 to ad1f305 Compare April 9, 2024 07:49
@ader1990
image_to_vm: add support for hyper-v vhdx format
7d4917d 
Add support for Gen 2 Hyper-V VMs.

`./image_to_vm` tool has now a new supported format: `hyperv_vhdx`,
that produces .vhdx dynamic disks.

How to use:

```bash
 ./image_to_vm.sh --from ../build/images/amd64-usr/developer-latest/ --format hyperv_vhdx
```

See: flatcar/Flatcar#1009

Uses PR: flatcar/bootengine#92

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
@ader1990 ader1990 force-pushed the ader1990/hyperv-vhdx-support branch from ad1f305 to 7d4917d Compare April 9, 2024 07:52
@ader1990 ader1990 merged commit 385b929 into main Apr 9, 2024
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jepio jepio jepio approved these changes

@pothos pothos Awaiting requested review from pothos

Assignees

No one assigned

Labels

main

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ader1990 @jepio @pothos @dongsupark