Conversation
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
c46fc32 to
a701d71
Compare
krnowak
approved these changes
Mar 5, 2024
| // Here, we match the cloud-init set. | ||
| // https://github.com/canonical/cloud-init/commit/c1a2047cf291 | ||
| - // https://github.com/coreos/ignition/issues/1806 | ||
| + // https://github.com/flatcar/ignition/issues/1806 |
Member
There was a problem hiding this comment.
Heh, this looks like an artifact of an overeager search-and-replace. ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we upgrade Ignition to 2.18.0. Not so much to say regarding the update, most of the heavy lifting has been done in the 2.17.0 upgrade (#1680)
I updated the changelog instead of creating a new one, since we did not release with Ignition 2.17.0 yet.
Size of the binary is +5Mb
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.Closes: flatcar/Flatcar#1359 and related to: #1683