Conversation
9bba769 to
6164ce9
Compare
illume
left a comment
There was a problem hiding this comment.
Looking good.
(I started a review, but it took a while... so am pausing for lunch. After I will test it out too.)
It's not clear to me why you didn't make extraFiles just files, and get rid of the existing file fields? Seems like it would make it less code and edge cases. I guess because it's quite an invasive change to do that?
Yeah, I considered that, but it'd require a migration, and since we require at least one file to be associated with the package (the reason why the legacy code-base had the file as part of the package), I thought we may as well keep it like this. |
d5f625e to
a026f50
Compare
|
When I run 22:05:54-rene~/dev/nebraska (multi-pkg)$ git diff
diff --git a/backend/test/api/flatcar_package_test.go b/backend/test/api/flatcar_package_test.go
index 3bd21bd..5fdc1aa 100644
--- a/backend/test/api/flatcar_package_test.go
+++ b/backend/test/api/flatcar_package_test.go
@@ -10,10 +10,11 @@ import (
"testing"
"github.com/google/uuid"
- "github.com/kinvolk/nebraska/backend/pkg/config"
- "github.com/kinvolk/nebraska/backend/pkg/server"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
+
+ "github.com/kinvolk/nebraska/backend/pkg/config"
+ "github.com/kinvolk/nebraska/backend/pkg/server"
)
func TestHostFlatcarPackage(t *testing.T) { |
|
I've tested it with a Flatcar client and it works well (it ignored the second package). |
The omaha protocol supports multiple packages and we need to also allow several files in a response. Due to how Nebraska structures its packages internally, this commit implements this feature as "extra files" which can optionally be added to each package.
This will be needed and was extracted from the Headlamp project.
This commit adds the needed UI and API requests related to supporting extra files in packages.
While we should fix this. It's not related to the PR. |
|
Thanks everyone! |
fixes #473