Add test case: cl.update.payload-boot-part-too-small#638
Merged
ader1990 merged 1 commit intoflatcar:mainfrom Aug 14, 2025
Merged
Add test case: cl.update.payload-boot-part-too-small#638ader1990 merged 1 commit intoflatcar:mainfrom
ader1990 merged 1 commit intoflatcar:mainfrom
Conversation
2 tasks
tormath1
reviewed
Jul 10, 2025
Contributor
Author
|
One thing I noticed and it is worth sharing here: when the update fails because the space in /boot partition is not enough to copy the new initrd (/boot/flatcar/vmlinuz-b), the update-engine service throws an error without cleaning up the file I would suggest to have a reboot added to this test workflow to see if the machine in this state survives. |
chewi
approved these changes
Jul 10, 2025
Contributor
chewi
left a comment
There was a problem hiding this comment.
Thanks for this. I always meant to see what the actual behaviour was, but I never got around to checking.
pothos
reviewed
Aug 7, 2025
This test case makes sure that the Flatcar upgrade fails if the update payload contains an initrd that has a bigger size than the free space in the /boot partition. Currently, the /boot partition free space is around 70 MB. The test case is Writing 20 MB on the /boot partition before starting the upgrade, so that it makes sure there is not enough space for the upgrade to complete. The stable channel has now around one vmlinuz plus around 15MB free (that s why 20MB has been chosen). NOTE: this test's expected result is to make sure that the upgrade FAILS if there is not enough /boot partition space, and at the same time, verifies that Flatcar can still boot with its currrent version after the failure. Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
4707d4d to
9364539
Compare
tormath1
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update: boot: add cl.update.payload-boot-part-too-small test case
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.