kola: Add tests for encrypted root disks with TPM PCR binding#521
Merged
pothos merged 2 commits intoflatcar-masterfrom Apr 11, 2024
Merged
kola: Add tests for encrypted root disks with TPM PCR binding#521pothos merged 2 commits intoflatcar-masterfrom
pothos merged 2 commits intoflatcar-masterfrom
Conversation
907ca74 to
0ae7f16
Compare
As documented in flatcar/flatcar-website#317 we can use PCR binding in Flatcar with some limitations and workarounds. I think we should be able to get rid of the first boot PCR difference by handling the first-boot flag detection in userspace and if we can guarantee that the outcome of setting the first boot or not is the same, i.e., we would have to always measure the effective Ignition config. For the rebinding on update the best bet we have is to create a Flatcar variant with sd-boot for signed PCR policies. Anyway, these are future topics and it's already good that we can make some encryption setups work.
ader1990
reviewed
Apr 10, 2024
| // Note: Keep the two below configs in sync with those | ||
| // documented in the Flatcar TPM docs. | ||
| // Ideally the reboot wouldn't be needed (or done in the initrd?) | ||
| IgnitionConfigRootCryptenrollPcrNoUpdate = conf.Butane(`--- |
Contributor
There was a problem hiding this comment.
off-topic: would be a separate bigger PR: I think it would be nice at some time to have the ignition/butane yaml/jsons in a separate folder/file for each test, to be able to better track changes in the code vs changes in the metadata.
krnowak
reviewed
Apr 11, 2024
krnowak
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As documented in flatcar/flatcar-website#317 we can use PCR binding in Flatcar with some limitations and workarounds. I think we should be able to get rid of the first boot PCR difference by handling the first-boot flag detection in userspace and if we can guarantee that the outcome of setting the first boot or not is the same, i.e., we would have to always measure the effective Ignition config. For the rebinding on update the best bet we have is to create a Flatcar variant with sd-boot for signed PCR policies. Anyway, these are future topics and it's already good that we can make some encryption setups work.
How to use
Testing done
Tested both new tests with the image from flatcar/scripts#1861