docker: extend restart test case#447
Merged
tormath1 merged 2 commits intoflatcar-masterfrom Aug 11, 2023
Merged
Conversation
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
4 tasks
8f681e9 to
3adeccb
Compare
krnowak
approved these changes
Aug 11, 2023
kola/tests/docker/docker.go
Outdated
|
|
||
| // kill it | ||
| c.MustSSH(m, "sudo kill "+string(pid)) | ||
| c.MustSSH(m, fmt.Sprintf("sudo kill -%s %s ", signal, string(pid))) |
Member
There was a problem hiding this comment.
Suggested change
| c.MustSSH(m, fmt.Sprintf("sudo kill -%s %s ", signal, string(pid))) | |
| c.MustSSH(m, fmt.Sprintf("sudo kill -%s %s", signal, string(pid))) |
SIGHUP has been seen to be used by third party tools to restart containerd. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
3adeccb to
f5448cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also: flatcar/Flatcar#1157
It passes with current Flatcar releases but not if you use SIGHUP signal.