kola/tests: Add test for /etc overlay upcopy prevention and cleanup#414
Merged
pothos merged 1 commit intoflatcar-masterfrom Feb 28, 2023
Merged
kola/tests: Add test for /etc overlay upcopy prevention and cleanup#414pothos merged 1 commit intoflatcar-masterfrom
pothos merged 1 commit intoflatcar-masterfrom
Conversation
3f7a148 to
359d000
Compare
krnowak
approved these changes
Feb 28, 2023
The /etc overlayfs mount is there to be able to update the lowerdir file and this only works if we have no unwanted duplicates in the upperdir (i.e., the /etc folder). Add tests to check against upcopies caused by, e.g., systemd-tmpfiles and to check that duplicates get removed on reboot (introduced in flatcar-archive/coreos-overlay#2482).
966daab to
cdfcc23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /etc overlayfs mount is there to be able to update the lowerdir file and this only works if we have no unwanted duplicates in the upperdir (i.e., the /etc folder).
Add tests to check against upcopies caused by, e.g., systemd-tmpfiles and to check that duplicates get removed on reboot (introduced in flatcar-archive/coreos-overlay#2482).
How to use
Expected to pass for flatcar-archive/coreos-overlay#2482
Testing done
CI
and local run of
cl.overlay.cleanup