test/ignition: add networkd translation test#334
Merged
tormath1 merged 3 commits intoflatcar-masterfrom Jun 3, 2022
Merged
Conversation
this test can actually be used to identify any regression with ign-converter and Ignition translation from 2 to 3. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
This commit creates a dummy network interface with a dummy IP assigned. With recent Ignition, `networkd` is no more used and should be translated to `files` section. This test ensures that we keep the `networkd` behavior by translating it with `ign-converter`. This test lives with an existing test (both are independant) to not add a new test and it will run only on QEMU. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
2 tasks
dongsupark
approved these changes
May 20, 2022
Member
dongsupark
left a comment
There was a problem hiding this comment.
Looks good.
Probably add changelog?
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we add a new test to ensure
networkdIgnition from spec 2.x is correctly translated tofilesfrom spec 3.x and applied correctly.This has been tested with current stable (where
networkdis still supported) and with flatcar-archive/coreos-overlay#1910Related to: flatcar/Flatcar#741
networkdis still supported)