Merged
Conversation
Member
Author
|
Base is chosen intentionally - when tormath1/bump-go is merged this PR will be re-targeted at flatcar-master. |
a32561d to
a33872b
Compare
3 tasks
tormath1
reviewed
Apr 13, 2022
a33872b to
fe343af
Compare
tormath1
approved these changes
Apr 13, 2022
Contributor
tormath1
left a comment
There was a problem hiding this comment.
Thanks ! This is cool. If I understand correctly, we would also need to update GCP testing script to supply --gce-gvnic for supported versions ?
Member
Author
|
Yes, we'll probably add a 'cl.internet' test with this option to the GCP testing. |
This is a result of doing: go get -u google.golang.org/api go mod tidy go mod vendor The updated APIs are needed to be able to enable GVNIC.
Published images now automatically run with UEFI boot mode and have opt-in support for GVNIC.
fe343af to
daf34b7
Compare
Member
Author
|
Will merge this after the GCP vnic support is cherry-picked everywhere. |
Member
Author
|
The coreos-overlay PR has been cherry-picked to everything back to 3033, so it is now safe to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcp image features
This PR marks published GCP images as supporting UEFI and GVNIC.
Marking the images as UEFI automatically makes instances boot with UEFI and have access to a VTPM.
Marking the image as support GVNIC does not automatically make it active but allows users to choose GVNIC. Therefore I intend to backport flatcar-archive/coreos-overlay#1802 to all releases. For kola testing a new flat is added that enables GVNIC on tested instances.
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
Tested here: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/5373/cldsv/, fetch the latest os/kola/gce console logs and look for gve/gvnic/EFI.
changelog/directory (user-facing change, bug fix, security fix, update)