Skip to content

kola/tests: Add test for runtime switching to cgroupv1#298

Merged
jepio merged 3 commits intoflatcar-masterfrom
jepio/cgroup1-test
Mar 1, 2022
Merged

kola/tests: Add test for runtime switching to cgroupv1#298
jepio merged 3 commits intoflatcar-masterfrom
jepio/cgroup1-test

Conversation

@jepio
Copy link
Copy Markdown
Member

@jepio jepio commented Feb 23, 2022

kola/tests: Add test for runtime switching to cgroupv1

Add test illustrating switching to cgroupv1 with no reboot.

How to use

Run test with this PR: flatcar-archive/coreos-overlay#1666

Testing done

CI running

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)

@pothos
Copy link
Copy Markdown
Member

pothos commented Feb 24, 2022

I think we need a more high-level test, too. I think a variant of the kubeadm tests (maybe just one specific configuration) would be helpful to assert that a system booted up this way is actually able to run Kubernetes. That's the only concern I have, otherwise the changes look good together.

@tormath1
Copy link
Copy Markdown
Contributor

tormath1 commented Feb 24, 2022

@pothos good idea for the kubadm test. I think we can easily add a cgroupv1 boolean field to one of the tested version to conditionally add the /etc/flatcar-cgroupv1 file to the provisioning.

Kubernetes should easily follow: https://github.com/flatcar-linux/mantle/blob/465025f7eb701a22b12b6c1cdffae231c20f40f8/kola/tests/kubeadm/templates.go#L284-L287

@tormath1
Copy link
Copy Markdown
Contributor

@jepio test is looking good to me. Can you maybe add a changelog entry in the added section ?

@jepio jepio force-pushed the jepio/cgroup1-test branch 2 times, most recently from 4f2a738 to abc9b13 Compare February 25, 2022 12:55
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Test that with the fallback to cgroupv1, kubeadm based clusters work.
This test covers kubernetes v1.21 only to not explode the test time.
@jepio jepio force-pushed the jepio/cgroup1-test branch from c208100 to b40ccac Compare February 25, 2022 13:34
@jepio
Copy link
Copy Markdown
Member Author

jepio commented Feb 25, 2022

@tormath1 @pothos I've added tests for cgroupv1+k8s v1.21.*. Search for cgroupfs in the console output here: http://jenkins.infra.kinvolk.io:8080/job/os/job/kola/job/qemu/3761/console.

@jepio jepio merged commit 1dba55f into flatcar-master Mar 1, 2022
@jepio jepio deleted the jepio/cgroup1-test branch March 1, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants