kola/tests/etcd: add name: to one CLC#259
Merged
tormath1 merged 1 commit intoflatcar-masterfrom Dec 16, 2021
Merged
Conversation
Using both command line option and environment variable is forbidden since `etcd/v3`. It happens quite a lot that users override default `etcd` name (`machine-id`) using `CLC` through the `name: ` key. In this case it fails because we will have both `ETCD_NAME` and `--name` in the runtime. This patch overrides the name in CLC in order to reproduce this behavior and prevent regression in the next release. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
3c56f07 to
95bae5c
Compare
Member
|
@tormath1: Can this be merged or is it waiting for anything else? |
Contributor
Author
|
@krnowak I was thinking about merging this after the next release. Otherwise nightlies are going to fail for |
Member
|
Ah, cool. No problem, let's wait then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using both command line option and environment variable is forbidden
since
etcd/v3.It happens quite a lot that user override default
etcdname(
machine-id) usingCLCthrough thename:key.In this case it fails because we will have both
ETCD_NAMEand
--namein the runtime.This patch overrides the name in CLC in order to reproduce this behavior
and prevent regression in the next release.
Signed-off-by: Mathieu Tortuyaux mtortuyaux@microsoft.com
This test is currently failing with current releases - it has to be merged with flatcar-archive/coreos-overlay#1444.
Changelog entry is not required IMHO.