Merged
Conversation
Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
5020554 to
a47e9da
Compare
a47e9da to
9b0e064
Compare
we currently ship etcdctl/v3 but it defaults to v2 so now we explicit require to use v3 Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
9b0e064 to
0277ef6
Compare
added 2 commits
August 24, 2021 10:52
this check is quite redundant with the other tests - beside it heavily relies on V2 HTTP api which is quite painful to maintain accross the various version of etcd. Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
jepio
approved these changes
Aug 24, 2021
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the tests rely on
etcdand use theGetClusterHealthmethod to ensure the etcd cluster is up and running. In this PR; we upgradedetcdand it seems now the defaultetcdctlversion is V3.It should fix the following tests:
Note for the reviewers
I first attended to support both v2/v3 but it becomes quickly an unmaintainable mess - so I removed the
setKeys/checkKeysfrom thecl.etcd-member.discovery. REST APIs from v2 to v3 are not the same at all + v3 APIs between 3.3.35 (current etcd version that we ship) and 3.5 does not have the same prefix neither... Since this check is quite redundant with the others who are usingetcdctldirectly we can safely remove it.How to use
Testing done
cl.etcd-member.discoverycl.etcd-member.discovery