Merged
Conversation
14 tasks
pothos
reviewed
Aug 19, 2021
Contributor
Author
|
@pothos thanks for the review - comment has been addressed ! |
pothos
approved these changes
Aug 19, 2021
added 2 commits
August 19, 2021 17:07
`torcx` unpack was randomly failing so it `torcx-generator` was not fully ran so `docker` was unable to run Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
SELinux should not be controlled from the test itself; by default it's always enabled on arch != ARM64. See ./platform/util.go Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
b762eab to
a2f0182
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we pull two fixes for ARM64 tests suite:
torcxwas randomly failing to unpack Docker (-> no Docker)setenforce 1indocker.usernstest (see the commit body for thewhy?)