kola/kubeadm: fix CNI selection#205
Merged
tormath1 merged 1 commit intoflatcar-masterfrom Aug 12, 2021
Merged
Conversation
krnowak
reviewed
Aug 12, 2021
|
|
||
| func init() { | ||
| for _, CNI := range CNIs { | ||
| cni := CNI |
Member
There was a problem hiding this comment.
I see now that this is variable capturing in the Run function that bit us here. Nasty. Would a comment about the fact be helpful here?
Contributor
Author
There was a problem hiding this comment.
Yes for sure. Actually, this section will be replaced by a new one from this PR (#196) - and a comment is already there to explain while we need such a thing (see https://github.com/kinvolk/mantle/pull/196/files#diff-833c725698d5fe10161a1c491a560567f1473d7541658c722022bc45db2d4c3fR88-R95)
krnowak
approved these changes
Aug 12, 2021
Member
krnowak
left a comment
There was a problem hiding this comment.
Looks good. You probably want to squash the fixup commit though. Unless github does it for you when merging.
register action was keeping the latest occurence of `CNI` so it was basically always testing the `cilium` CNI. ... it happens. Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
3308011 to
f819ffe
Compare
Contributor
Author
|
@krnowak yes.. Github does not handle yet the |
sayanchowdhury
approved these changes
Aug 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
register action was keeping the latest occurence of
CNIso it wasbasically always testing the
ciliumCNI.... it happens.
The issue was already being fixed into #196 but it's better to be merged now to confirm that flatcar-archive/coreos-overlay#1181 is solving the actual
flannelissue raised in #196 (comment)