kola/kubeadm: test various CNIs#182
Merged
tormath1 merged 2 commits intoflatcar-masterfrom Jul 29, 2021
Merged
Conversation
4500370 to
6d604ee
Compare
pothos
reviewed
Jul 29, 2021
kola/tests/kubeadm/templates.go
Outdated
| kubectl apply -f calico.yaml | ||
| {{ end }} | ||
| {{ if eq .CNI "flannel" }} | ||
| curl -sSL https://raw.githubusercontent.com/flannel-io/flannel/master/Documentation/kube-flannel.yml > kube-flannel.yml |
Member
There was a problem hiding this comment.
Suggested change
| curl -sSL https://raw.githubusercontent.com/flannel-io/flannel/master/Documentation/kube-flannel.yml > kube-flannel.yml | |
| curl -sSfL https://raw.githubusercontent.com/flannel-io/flannel/master/Documentation/kube-flannel.yml > kube-flannel.yml |
We should fail on 404
pothos
reviewed
Jul 29, 2021
|
|
||
|
|
||
|
|
||
| curl -sSL https://raw.githubusercontent.com/flannel-io/flannel/master/Documentation/kube-flannel.yml > kube-flannel.yml |
pothos
reviewed
Jul 29, 2021
Member
pothos
left a comment
There was a problem hiding this comment.
Two small issues with fetching via curl but otherwise feel free to merge
Contributor
Author
|
thanks @pothos for reviewing. Comments have been addressed. FYI Once the CI 🟢 I'll rebase and merge. |
pothos
approved these changes
Jul 29, 2021
added 2 commits
July 29, 2021 11:43
this commit adds logic and templates to test more CNIs in a kubernetes context. - calico - flannel - cilium Tests have a common implementation but it differs using templates following the tested CNI Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
this testdata will assert that the installation scripts are well rendered following the CNI, it also allows to help reproduce issues with the tests using directly the testdata Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
708bf9d to
11d3514
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we try to cover more kubernetes use cases by testing different CNIs.
How to use
closes: flatcar/Flatcar#309