Merged
Conversation
Now that flannel itself is started with Docker, we can't start Flannel before Docker which results in a deadlock but instead have to rely on Flannel to restart Docker to apply its settings.
The nodes were assumed to use coreos-cloudinit when an empty configuation is given and in result, set up /etc/environment. Use coreos-metadata (afterburn) explicitly to find the IP address on any cloud environment. Also, add a few more comments about the set up and force that no local etcd can start on the K8s controller.
Placing the symlink in /run/flannel/ could fail if the directory did not exist before. Instead of setting up a symlink, directly write the template to /run/flannel/ which takes care of creating the directory.
The 10.x.0.0/16 networks overlapped with the private network 10.0.0.0/8 used in Equinix Metal and can also overlap with Digital Ocean private IP addresses. The 192.168.0.0/16 network seems to be not used by AWS nor the internal Docker network at the moment.
The tests were only running on GCE and by enabling it on more platforms we have a better chance to catch errors early. For VMware in our setup there are 4 tests in parallel for 12 slots and thus we have to limit the cluster size to 3 nodes.
The kubelet-wrapper script will be removed.
1dc1525 to
184fdbf
Compare
Member
Author
|
The test should still work with rkt instead of docker, otherwise we can add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that flannel itself is started with Docker, we can't start Flannel
before Docker which results in a deadlock but instead have to rely on
Flannel to restart Docker to apply its settings.
Placing the symlink in /run/flannel/ could fail if the directory did
not exist before. Instead of setting up a symlink, directly write the
template to /run/flannel/ which takes care of creating the directory.
The nodes were assumed to use coreos-cloudinit when an empty
configuation is given and in result, set up /etc/environment.
Use coreos-metadata (afterburn) explicitly to find the IP address
on any cloud environment. Also, add a few more comments about the
set up and force that no local etcd can start on the K8s controller.
The 10.x.0.0/16 networks overlapped with the private network 10.0.0.0/8
used in Equinix Metal and can also overlap with Digital Ocean private
IP addresses. The 192.168.0.0/16 network seems to be not used by AWS
nor the internal Docker network at the moment.
The tests were only running on GCE and by enabling it on more platforms
we have a better chance to catch errors early.
For VMware in our setup there are 4 tests in parallel for 12 slots and
thus we have to limit the cluster size to 3 nodes.
The kubelet-wrapper script will be removed.
Can be done in a follow-up PR:
TODO: Replace running
kubelet-wrapperwith Docker, remove supportingrktas K8s runtimeTODO: Try to fix running on
esxandpacketplatformsHow to use/testing done
Tested on AWS, DO, GCE