Restrict Permissions of grub/menu.lst#113
Merged
chewi merged 1 commit intoflatcar:flatcar-masterfrom Jun 12, 2025
Merged
Conversation
This is described in the following issue: flatcar/Flatcar#296 Setting the `Options=umask` parameter as that behaviour is well documented by systemd: https://www.freedesktop.org/software/systemd/man/latest/systemd.mount.html#Options.
Contributor
|
I've sort of tested this by copying and adding the change to /run/systemd/system/boot.mount. /boot is an autofs, so you can see the result if you don't access it before that. I'll run this through CI though. |
Contributor
|
The |
Contributor
|
CI has passed with the Kola fix. Just need to get that merged first. |
jepio
approved these changes
Jun 12, 2025
Contributor
|
Thanks @justdan96 for the proposed fix, and sorry for the delay here - this has been somehow missed. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is described in the following issue:
flatcar/Flatcar#296
Setting the
Options=umaskparameter as that behaviour is well documented by systemd: https://www.freedesktop.org/software/systemd/man/latest/systemd.mount.html#Options.Restrict Permissions of grub/menu.lst
Previously the permissions of grub/menu.lst were 0755, this PR corrects those permissions which helps with CIS compliance.
How to use
Test new unit file works with Flatcar installation.
Testing done
None yet.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.Closes: flatcar/Flatcar#296