Merged
Conversation
* added vultr to oem reg * Fix bad endpoint Co-authored-by: Mike Biondi <biondizzle@gmail.com> Co-authored-by: eb3095 <45504889+eb3095@users.noreply.github.com> Signed-off-by: Vincent Batts <vbatts@kinvolk.io>
33e2ec9 to
818c393
Compare
pothos
reviewed
Jun 16, 2020
|
|
||
| // The vultr provider fetches a remote configuration from the vultr | ||
| // user-data metadata service URL. | ||
| // https://web.archive.org/web/20190513194756/https://www.vultr.com/metadata/#user |
Member
There was a problem hiding this comment.
This link says that user data is under /user-data/user-data, not latest/user-data – are both correct?
Member
There was a problem hiding this comment.
Yeah, that's also something already upstream: https://github.com/coreos/ignition/blob/master/internal/providers/vultr/vultr.go
That uses /user-data/user-data
Contributor
|
Yes both are infact correct. The first end is a regex.
…On Tue, Jun 16, 2020, 10:42 AM Kai Lüke ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In internal/providers/vultr/vultr.go
<#13 (comment)>:
> +//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// The vultr provider fetches a remote configuration from the vultr
+// user-data metadata service URL.
+// https://web.archive.org/web/20190513194756/https://www.vultr.com/metadata/#user
Yeah, that's also something already upstream:
https://github.com/coreos/ignition/blob/master/internal/providers/vultr/vultr.go
That uses /user-data/user-data
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK3FS6IRCDFNP4N2RLCFTADRW6AFVANCNFSM4NF55MXA>
.
|
Member
Author
|
👍 |
pothos
approved these changes
Jun 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @eb3095
ref eb3095/ignition#2
Co-authored-by: Mike Biondi biondizzle@gmail.com
Co-authored-by: eb3095 45504889+eb3095@users.noreply.github.com
Signed-off-by: Vincent Batts vbatts@kinvolk.io
oem: Add Vultr as a provider
How to use
./bin/amd64/ignition -oem vultr ...Testing done
Have not