Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

net-fs/samba: EAPI=7, new USE flags, remove deps on icu#864

Merged
dongsupark merged 5 commits intomainfrom
dongsu/optimize-samba
Mar 1, 2021
Merged

net-fs/samba: EAPI=7, new USE flags, remove deps on icu#864
dongsupark merged 5 commits intomainfrom
dongsu/optimize-samba

Conversation

@dongsupark
Copy link
Copy Markdown
Contributor

@dongsupark dongsupark commented Feb 25, 2021

Now that portage was updated to the latest version, we should update EAPI to 7.
It is mainly to allow ebuilds to make BDEPEND contain real build-time dependencies, not runtime ones.

Introduce a USE flag spotlight, to be able to disable the spotlight backend by default, as it is not needed by Linux.
Introduce a USE flag rededit, to be able to disable the rededit tool if needed.
Introduce a USE flag glusterfs, to be able to disable the glusterfs by default.
Introduce a USE flag ntvfs, to be able to disable the ntvfs-fileserver by default.
Since the docbook-xsl-stylesheets and libxslt are needed only at build time, we should move those deps to BDEPEND.

dev-libs/icu is needed only if spotlight is enabled. If not enabled, we should not pull in icu.

To minimize the size of bundled libraries of Samba, we should install only the ldb backend by default.

Disable unnecessary regedit in samba to minimize the package size.

This PR should be merged together with flatcar-archive/portage-stable#150 .

See also a Gentoo PR gentoo/gentoo#19650 , which is slightly different from this one.

Fixes flatcar/Flatcar#346

Testing done

CI passed http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/2106/

@dongsupark dongsupark added enhancement New feature or request alpha main labels Feb 25, 2021
@dongsupark dongsupark changed the title [WIP] net-fs/samba: EAPI=7, new USE flags, remove deps on icu net-fs/samba: EAPI=7, new USE flags, remove deps on icu Feb 26, 2021
@dongsupark dongsupark force-pushed the dongsu/optimize-samba branch from fde59af to b359997 Compare February 26, 2021 10:13
Dongsu Park added 5 commits February 26, 2021 11:14
Now that portage was updated to the latest version, we should update
EAPI to 7. It is mainly to allow ebuilds to make BDEPEND contain real
build-time dependencies, not runtime ones.
Introduce a USE flag spotlight, to be able to disable the spotlight
backend by default, as it is not needed by Linux.

Introduce a USE flag rededit, to be able to disable the rededit
tool if needed.

Introduce a USE flag glusterfs, to be able to disable the glusterfs
by default.

Introduce a USE flag ntvfs, to be able to disable the ntvfs-fileserver
by default.

Since the docbook-xsl-stylesheets and libxslt are needed only
at build time, we should move those deps to BDEPEND.
dev-libs/icu is needed only if spotlight is enabled.
If not enabled, we should not pull in icu.
To minimize the size of bundled libraries of Samba, we should install
only the "ldb" backend by default.
Disable unnecessary regedit in samba to minimize the package size.
@dongsupark dongsupark force-pushed the dongsu/optimize-samba branch from b359997 to a951b09 Compare February 26, 2021 10:15
@dongsupark dongsupark marked this pull request as ready for review February 26, 2021 10:15
@dongsupark dongsupark requested a review from a team February 26, 2021 10:15
@dongsupark
Copy link
Copy Markdown
Contributor Author

CI passed

Copy link
Copy Markdown
Contributor

@margamanterola margamanterola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsupark dongsupark merged commit 40820e3 into main Mar 1, 2021
@dongsupark dongsupark deleted the dongsu/optimize-samba branch March 1, 2021 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

alpha enhancement New feature or request main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize dependencies of samba

2 participants