This repository was archived by the owner on May 30, 2023. It is now read-only.
net-fs/samba: EAPI=7, new USE flags, remove deps on icu#864
Merged
dongsupark merged 5 commits intomainfrom Mar 1, 2021
Merged
Conversation
This was referenced Feb 25, 2021
fde59af to
b359997
Compare
added 5 commits
February 26, 2021 11:14
Now that portage was updated to the latest version, we should update EAPI to 7. It is mainly to allow ebuilds to make BDEPEND contain real build-time dependencies, not runtime ones.
Introduce a USE flag spotlight, to be able to disable the spotlight backend by default, as it is not needed by Linux. Introduce a USE flag rededit, to be able to disable the rededit tool if needed. Introduce a USE flag glusterfs, to be able to disable the glusterfs by default. Introduce a USE flag ntvfs, to be able to disable the ntvfs-fileserver by default. Since the docbook-xsl-stylesheets and libxslt are needed only at build time, we should move those deps to BDEPEND.
dev-libs/icu is needed only if spotlight is enabled. If not enabled, we should not pull in icu.
To minimize the size of bundled libraries of Samba, we should install only the "ldb" backend by default.
Disable unnecessary regedit in samba to minimize the package size.
b359997 to
a951b09
Compare
Contributor
Author
|
CI passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that portage was updated to the latest version, we should update
EAPIto 7.It is mainly to allow ebuilds to make
BDEPENDcontain real build-time dependencies, not runtime ones.Introduce a USE flag
spotlight, to be able to disable the spotlight backend by default, as it is not needed by Linux.Introduce a USE flag
rededit, to be able to disable the rededit tool if needed.Introduce a USE flag
glusterfs, to be able to disable the glusterfs by default.Introduce a USE flag
ntvfs, to be able to disable the ntvfs-fileserver by default.Since the
docbook-xsl-stylesheetsandlibxsltare needed only at build time, we should move those deps toBDEPEND.dev-libs/icuis needed only if spotlight is enabled. If not enabled, we should not pull in icu.To minimize the size of bundled libraries of Samba, we should install only the
ldbbackend by default.Disable unnecessary
regeditin samba to minimize the package size.This PR should be merged together with flatcar-archive/portage-stable#150 .
See also a Gentoo PR gentoo/gentoo#19650 , which is slightly different from this one.
Fixes flatcar/Flatcar#346
Testing done
CI passed http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/2106/