This repository was archived by the owner on May 30, 2023. It is now read-only.
coreos-base/gmerge: Stop installing gmerge script#828
Merged
Conversation
It is not used anywhere during the build process, thus drop it. Dropping it makes it easier to port this ebuild to python3, since there will be only one script to port to python3. The `emerge-gitclone` script will need porting anyway, because it imports portage code, which will become python3 after the update. Most likely the package should be then renamed to `coreos-base/emerge-gitclone`, but this can be done later.
9138cde to
d0b39c1
Compare
dongsupark
approved these changes
Feb 5, 2021
Contributor
dongsupark
left a comment
There was a problem hiding this comment.
Yeah, I cannot figure out why gmerge was installed.
It was just like that since the beginning.
coreos-base/cros-devutils still calls gmerge, but only if ! cros_host.
So it looks ok to remove gmerge.
Contributor
Author
|
Yeah, and funnily enough, gmerge is gone at upstream - https://chromium.googlesource.com/chromiumos/platform/dev-util/+/refs/heads/main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not used anywhere during the build process, thus drop
it. Dropping it makes it easier to port this ebuild to python3, since
there will be only one script to port to python3. The
emerge-gitclonescript will need porting anyway, because it importsportage code, which will become python3 after the update.
Most likely the package should be then renamed to
coreos-base/emerge-gitclone, but this can be done later.Test build passed just fine without the tool. It's being pulled into dev container through coreos-base/dev-util package.
Test build: http://localhost:9091/job/os/job/toolchains/1294/