This repository was archived by the owner on May 30, 2023. It is now read-only.
app-emulation,torcx: delete docker 1.12#826
Merged
dongsupark merged 7 commits intomainfrom Feb 4, 2021
Merged
Conversation
added 7 commits
February 4, 2021 16:56
One of the torcx profiles in Flatcar is for docker 1.12, which is outdated since a long time. It takes ~27 MB of space in production images almost for no reason. We can and should delete docker 1.12. After deletion: ``` $ df -h /usr Filesystem Size Used Avail Use% Mounted on /dev/mapper/usr 985M 843M 91M 91% /usr ```
delete torcx profiles for docker 1.12
Delete torcx config file needed only for Docker 1.12. Note, let's keep the remaining file name as before, `docker-1.12-no.json`, to be consistent with naming scheme of the torcx repo itself of Flatcar.
Now that docker 1.12 is gone, we can also delete containerd 0.2.5, which had dependency on docker 1.12.
Now that docker 1.12 is gone, we can delete `app-emulation/runc` 1.0.0_rc2, which had dependency on docker 1.12. Note, we do not delete `app-emulation/docker-runc` 1.0.0_rc2, because that one is needed by Docker 17.03.
Now that `app-emulation/runc` is gone, we can delete also the negative dependency on `app-emulation/runc` from RDEPEND of `app-emulation/docker-runc`.
Now that `app-emulation/runc` is gone, we can also delete it from `package.use` in profiles.
This was referenced Feb 4, 2021
krnowak
approved these changes
Feb 4, 2021
Contributor
krnowak
left a comment
There was a problem hiding this comment.
This will need some extra release note. Also, are there some docs that mention docker 1.12 to be removed?
Contributor
Author
Sure, we will explicitly say about that in the next Alpha release note. |
Contributor
|
I thought that in torcx there is also something to remove, but if we document that even though the mechanics are still in place, they are not supported, it's also fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the torcx profiles in Flatcar is for docker 1.12, which is outdated since a long time.
It takes ~27 MB of space in production images almost for no reason.
We should delete docker 1.12.
After deletion:
Note, let's keep the remaining file name as before,
docker-1.12-no.json, to be consistent with naming scheme of the torcx repo itself of Flatcar.Now that docker 1.12 is gone, we can also delete containerd 0.2.5 and
app-emulation/runc1.0.0_rc2, which had dependencies on docker 1.12.Note, please do not get confused, we do not delete
app-emulation/docker-runc1.0.0_rc2, because that one is still needed by Docker 17.03.Fixes flatcar/Flatcar#339.
This PR should be merged together with flatcar/scripts#116.
How to use
Testing done
CI passed: http://localhost:9091/job/os/job/manifest/1960/cldsv/
Note, the CI build was running including the deletion of Go 1.6, and it worked well.
Though the Go 1.6 part is not included in this PR, because if we delete Go 1.6 at once, the nightly build will be broken.
We should merge deletion of Go 1.6 one day after we merged this PR.