This repository was archived by the owner on May 30, 2023. It is now read-only.
Improve Flatcar behavior on GCE when using oslogin#592
Merged
margamanterola merged 2 commits intomainfrom Sep 22, 2020
Merged
Conversation
4ed5319 to
f57e5e1
Compare
This change updates to the latest oslogin version provided by Google. Since our last update, this was split into a different repo and the directory structure changed significantly. It also added group support, which needed to be added to the nsswitch.conf file that we ship. Flatcar users require docker group permissions, so ensure oslogin gives that permission by shipping a separate group.conf file that gets installed when oslogin is enabled.
f57e5e1 to
d0f7c9e
Compare
GCE recommends images to ship Python in them. Instead of shipping the binaries inside our vendor partition, install an alias that will download the latest official container, for both python2 and python3.
pothos
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve behavior on GCE
This change updates to the latest oslogin version provided by Google. Since our last update, this was split into a different repo and the directory structure changed significantly.
It also added group support, which needed to be added to the nsswitch.conf file that we ship. And the pam configuration got modified significantly.
On top of that, it also adds an alias for running Python, using the official container images and the suggested execution parameters.
How to use / Testing done
I've built the package with emerge-amd64-usr and it built and installed successfully. I also built and uploaded a GCE image and tested that oslogin works successfully on it. With this change, all of
gcloud,gsutil,pythonandpython3execute successfully.Fixes flatcar/Flatcar#186