Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

sys-apps/ignition: rework ignition patches#2187

Merged
tormath1 merged 2 commits intomainfrom
tormath1/ign-converter
Sep 27, 2022
Merged

sys-apps/ignition: rework ignition patches#2187
tormath1 merged 2 commits intomainfrom
tormath1/ign-converter

Conversation

@tormath1
Copy link
Copy Markdown
Contributor

@tormath1 tormath1 commented Sep 26, 2022

ign-converter is now part of the Ignition codebase, it should ease the maintaining of these patches.

Only the v24tov31 translation (and its tests) has been ported to the codebase.

Signed-off-by: Mathieu Tortuyaux mtortuyaux@microsoft.com


It pulls:

Relates to: flatcar/Flatcar#828

@tormath1 tormath1 force-pushed the tormath1/ign-converter branch from 043bf3d to a7242f8 Compare September 26, 2022 14:03
@tormath1 tormath1 marked this pull request as ready for review September 27, 2022 08:03
@tormath1 tormath1 requested a review from a team September 27, 2022 08:03
@pothos
Copy link
Copy Markdown
Contributor

pothos commented Sep 27, 2022

This would go to Alpha and Beta but not Stable, or? And maybe next week we backport it to Stable.

Copy link
Copy Markdown
Contributor

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great cleanup work! I have some suggestions on how to improve the docs for future reference but otherwise it looks good to merge.

@pothos
Copy link
Copy Markdown
Contributor

pothos commented Sep 27, 2022

What do you think about changing the default branch of https://github.com/flatcar/ignition back to flatcar-master to indicate that we keep this repo to preserve the currently used v0.36.2 tag on that branch?

@tormath1
Copy link
Copy Markdown
Contributor Author

What do you think about changing the default branch of https://github.com/flatcar/ignition back to flatcar-master to indicate that we keep this repo to preserve the currently used v0.36.2 tag on that branch?

I'm fine with it - and maybe we can sync again main with coreos/ignition ? (as we won't maintain the main branch anymore). Just to get back in sync with the upstream for this branch.

@tormath1
Copy link
Copy Markdown
Contributor Author

This would go to Alpha and Beta but not Stable, or? And maybe next week we backport it to Stable.

For now it can go only for alpha / beta (to be part of the next release). Backporting to stable only depends on whether we promote the next beta to stable or if we release a maintenance stable.

`ign-converter` is now part of the Ignition codebase, it should ease the
maintaining of these patches.

Only the v24tov31 translation (and its tests) has been ported to the codebase.

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1 tormath1 force-pushed the tormath1/ign-converter branch from 6031d81 to d31502e Compare September 27, 2022 09:48
@tormath1 tormath1 merged commit 2940c61 into main Sep 27, 2022
@tormath1 tormath1 deleted the tormath1/ign-converter branch September 27, 2022 09:58
@tormath1
Copy link
Copy Markdown
Contributor Author

cherry-picked to:

  • flatcar-3346
  • flatcar-3277

@tormath1
Copy link
Copy Markdown
Contributor Author

What do you think about changing the default branch of https://github.com/flatcar/ignition back to flatcar-master to indicate that we keep this repo to preserve the currently used v0.36.2 tag on that branch?

flatcar-master is now the default branch on flatcar/ignition.

@tormath1
Copy link
Copy Markdown
Contributor Author

adapted and backported on flatcar-3227 - hopefully this is the last time we ship 2.13.0 on Stable 🤞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants