Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

app-emulation: bring back docker-runc 1.0-rc2 for Docker 17.03#191

Merged
dongsupark merged 2 commits intoflatcar-master-alphafrom
dongsu/fix-docker-17-runc
Feb 28, 2020
Merged

app-emulation: bring back docker-runc 1.0-rc2 for Docker 17.03#191
dongsupark merged 2 commits intoflatcar-master-alphafrom
dongsu/fix-docker-17-runc

Conversation

@dongsupark
Copy link
Copy Markdown
Contributor

@dongsupark dongsupark commented Feb 27, 2020

The torcx profile docker-17.03 started not to work since it started pulling in docker-runc 1.0-rc10, with an error message flag provided but not defined: -console. That's because Docker 17.03 is incompatible with runc 1.0-rc4 or newer.

So the docker-17.03 profile needs to pull in docker-runc 1.0-rc2 like before. Bring back docker-runc 1.0-rc2 and its related patches that were removed.

Dongsu Park added 2 commits February 27, 2020 09:45
The torcx profile docker-17.03 start not to work since it started
pulling in docker-runc 1.0-rc10, with an error message 'flag provided
but not defined: -console'. That's because Docker 17.03 is incompatible
with runc 1.0-rc4 or newer. [1] So the docker-17.03 profile needs to
pull in docker-runc 1.0-rc2 like before. Bring back docker-runc 1.0-rc2
and its related patches that were removed.

[1] opencontainers/runc@244c9fc
@dongsupark dongsupark added bug Something isn't working alpha labels Feb 27, 2020
@dongsupark dongsupark requested a review from pothos February 27, 2020 08:57
@dongsupark dongsupark merged commit b21fb08 into flatcar-master-alpha Feb 28, 2020
@dongsupark dongsupark deleted the dongsu/fix-docker-17-runc branch February 28, 2020 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

alpha bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant