This repository was archived by the owner on May 30, 2023. It is now read-only.
Conversation
pothos
approved these changes
Apr 25, 2022
pothos
reviewed
Apr 25, 2022
Contributor
pothos
left a comment
There was a problem hiding this comment.
A changelog entry for bugfix would be good, or?
78a5d3b to
e9731cd
Compare
Contributor
Author
|
Can you check the changelog I added? |
pothos
reviewed
Apr 25, 2022
changelog/bugfixes/2022-04-25-fix-dev-container-module-builds.md
Outdated
Show resolved
Hide resolved
pahole is a build-time dependency of our kernel build, due to us setting CONFIG_BTF_DEBUG_INFO. If pahole is missing, a `make modules_prepare` with our kernel config results in symbols in the config changing. This will affect people building kernel modules against coreos-sources in the developer container, but not the SDK because pahole is already in sdk-depends. pahole is now an (explicit) BDEPEND of all the coreos-kernel/coreos-modules packages, and we'll make it an RDEPEND of coreos-sources so that it is pulled in whenever it might be necessary. Also add it to the coreos-dev package so that it is included in developer container by default, uncompressed size increase is <1MB.
e9731cd to
8a15e6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing pahole dependencies
pahole is a build-time dependency of our kernel build, due to us setting
CONFIG_BTF_DEBUG_INFO. If pahole is missing, a
make modules_preparewith ourkernel config results in symbols in the config changing. This will affect
people building kernel modules against coreos-sources in the developer
container, but not the SDK because pahole is already in sdk-depends.
How to use
Test the resulting developer container with nvidia.service on a GPU instance (e.g. NC6s_v3 in EastUS).
Testing done
Modified this line: https://github.com/flatcar-linux/coreos-overlay/blob/main/x11-drivers/nvidia-drivers/files/bin/install-nvidia#L7 to be
emerge -gkv pahole coreos-sourcesand verified that this allows the built modules to be probed. Without this, the module fails to load with this error message "module: x86/modules: Skipping invalid relocation target, existing value is nonzero for type 1...".Tested here: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/5487/cldsv/
changelog/directory (user-facing change, bug fix, security fix, update)`