This repository was archived by the owner on May 30, 2023. It is now read-only.
Merged
Conversation
c8c1217 to
a93c8a5
Compare
a93c8a5 to
66aad6d
Compare
Contributor
|
Aren't bits of mantle used by various things in scripts? |
Contributor
Author
|
If yes, they should use the container image, except for the original Jenkins pipeline that uses the binaries from Jenkins |
Contributor
Author
|
looks like |
Contributor
|
We're dismantling the SDK? |
1 task
Contributor
Author
|
I'll run a test build with flatcar/scripts#280 |
This was referenced Apr 20, 2022
66aad6d to
74e37c2
Compare
tormath1
approved these changes
Apr 21, 2022
Contributor
tormath1
left a comment
There was a problem hiding this comment.
That looks good to me - we should maybe go through the documentation to search for Mantle SDK mentions and update them consequently.
With the new mantle container image referenced by the scripts repo we don't need the mantle copy in the SDK anymore. Drop the mantle package and the unused kola-data package.
2a3e583 to
b3cfb95
Compare
pothos
added a commit
that referenced
this pull request
Apr 21, 2022
Drop mantle and kola-data from the SDK
pothos
added a commit
that referenced
this pull request
Apr 21, 2022
Drop mantle and kola-data from the SDK
pothos
added a commit
that referenced
this pull request
Apr 21, 2022
Drop mantle and kola-data from the SDK
pothos
added a commit
that referenced
this pull request
Apr 21, 2022
Drop mantle and kola-data from the SDK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new mantle container image referenced by the scripts repo we
don't need the mantle copy in the SDK anymore.
Drop the mantle package and the unused kola-data package.
How to use
pick for all channels
Goes with flatcar/scripts#280
Testing done
passed
changelog/directory (user-facing change, bug fix, security fix, update)