This repository was archived by the owner on May 30, 2023. It is now read-only.
sys-kernel: Revert change to forbid using xfrm id 0#1682
Merged
Conversation
54eebe5 to
be2468d
Compare
borkmann
approved these changes
Mar 2, 2022
borkmann
left a comment
There was a problem hiding this comment.
Thanks for your help, Kai! Much appreciated!
jepio
approved these changes
Mar 2, 2022
Contributor
|
Reading this (https://marc.info/?l=linux-netdev&m=164614735600855&w=2) it appears like only one patch needs to be reverted, not both? |
Contributor
Author
|
For Cilium yes, only the state change needs to be reverted but I think that in general we should not start failing something like |
Contributor
Author
|
Ok, actually this didn't work on Flatcar before :D I'm fine dropping the patch then and only keep the first. |
be2468d to
e92aa06
Compare
The change broke userspace (e.g., Cilium is affected because it used id 0 for the dummy state cilium/cilium#18789) and we decided to revert it to give the affected software more time to adapt (cf. https://marc.info/?t=164607426900002&r=1&w=2).
e92aa06 to
e585dcc
Compare
Contributor
Author
|
Picked for 3033, 3139, 3165 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes broke userspace (e.g., Cilium is affected because it used
id 0 for the dummy state cilium/cilium#18789)
and we decided to revert them to give the affected software more time
to adapt (cf. https://marc.info/?t=164607426900002&r=1&w=2).
How to use
Test that, e.g.,
works again.
Backport to all channels
Testing done
Ongoing
changelog/directory (user-facing change, bug fix, security fix, update)