This repository was archived by the owner on May 30, 2023. It is now read-only.
coreos-base/oem-ec2-compat: set correct console on arm64#1628
Merged
Conversation
0e1e3f8 to
12192dc
Compare
The default arm64 console (console=ttyAMA0) that is set by grub is wrong for EC2 arm64, so fix the value and enable earlycon.
12192dc to
d7b6064
Compare
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Contributor
|
The console.txt contents seem to be truncated to about last 80kb of logs. But this is probably outside the scope of this PR, right? |
Contributor
Author
|
EC2 buffers the last 64kB, we fetch the console twice before the test ends. It would need an asynchronous console-fetcher in kola to overcome this limitation, so yeah, out of scope. |
Contributor
|
Welp, still better than no file at all. Care to file an issue on mantle about this? Thanks. |
krnowak
approved these changes
Feb 11, 2022
Contributor
Author
|
New issue here flatcar/Flatcar#625 |
pothos
added a commit
that referenced
this pull request
Apr 28, 2022
coreos-base/oem-ec2-compat: set correct console on arm64
Contributor
|
Picked for flatcar-3033 and flatcar-3139 |
pothos
added a commit
that referenced
this pull request
Apr 28, 2022
coreos-base/oem-ec2-compat: set correct console on arm64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coreos-base/oem-ec2-compat: set correct console on arm64
The default console (console=ttyAMA0) that is set by grub is wrong for EC2 arm64, set it to console=ttyS0 manually to allow capturing console output. With the wrong setting the kola console log is empty.
How to use
Start an arm64 EC2 instance.
Testing done
CI passed and more data is found in console.txt (http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/4797/cldsv/)
changelog/directory (user-facing change, bug fix, security fix, update)