This repository was archived by the owner on May 30, 2023. It is now read-only.
app-admin/logrotate: Correct downstream changes to take effect#1442
Merged
app-admin/logrotate: Correct downstream changes to take effect#1442
Conversation
95a950b to
58be6b3
Compare
krnowak
approved these changes
Nov 22, 2021
Contributor
krnowak
left a comment
There was a problem hiding this comment.
The changes look good, let's wait for CI.
By accident the upstream files from the example folder got used, instead of the downstream files that were added in the files/ folder. Also, the configuration file didn't get installed. Use the right paths to install the downstream files.
58be6b3 to
4faed66
Compare
pothos
added a commit
that referenced
this pull request
Nov 23, 2021
app-admin/logrotate: Correct downstream changes to take effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By accident the upstream files from the example folder got used,
instead of the downstream files that were added in the files/ folder.
Also, the configuration file didn't get installed.
Use the right paths to install the downstream files.
How to use
Check that logrotate doesn't fail
Pick for flatcar-3066
Testing done
Booted https://bucket.release.flatcar-linux.net/flatcar-jenkins/developer/developer/boards/amd64-usr/2021.11.22+dev-flatcar-master-4222/flatcar_production_image.bin.bz2
and ran
sudo systemctl start logrotate.serviceandsystemctl status logrotate.serviceand it worked:Process: 958 ExecStart=/usr/bin/logrotate /usr/share/logrotate/logrotate.conf (code=exited, status=0/SUCCESS)