Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

Add app-arch/lbzip2 to the coreos ebuild dependencies#1221

Merged
pothos merged 2 commits intoflatcar-archive:mainfrom
aniruddha2000:aniruddha2000/add-lbzip2
Aug 30, 2021
Merged

Add app-arch/lbzip2 to the coreos ebuild dependencies#1221
pothos merged 2 commits intoflatcar-archive:mainfrom
aniruddha2000:aniruddha2000/add-lbzip2

Conversation

@aniruddha2000
Copy link
Copy Markdown
Contributor

@aniruddha2000 aniruddha2000 commented Aug 26, 2021

Add app-arch/lbzip2 to the coreos ebuild dependencies

Testing done

emerge-amd64-usr coreos-base/coreos
./build_image
Then checked in the flatcar instance that there is lbzip2 in the.

@pothos
Copy link
Copy Markdown
Contributor

pothos commented Aug 26, 2021

Would be great to remove bzip2 and set the symlink useflag for lbzip2 in profiles/coreos/base/package.use to have the bzip2 symlink installed. Besides checking for the lbzip2 binary we also need to check that lbzcat is there (probably a symlink itself).

@pothos
Copy link
Copy Markdown
Contributor

pothos commented Aug 26, 2021

You can also add a change here to point CROS_WORKON_COMMIT in coreos-base/coreos-init/coreos-init-9999.ebuild to 101e6c71ee2a07ef591eff3d9122a391713dbbf0 (the merge commit of the init repo)

@jepio jepio mentioned this pull request Aug 27, 2021
Closed
@pothos
Copy link
Copy Markdown
Contributor

pothos commented Aug 27, 2021

Ok, I think we should not use the symlink useflag as long as bzip2 is also installed. Maybe one is winning depending on how emerge installs the packages?

@aniruddha2000
Copy link
Copy Markdown
Contributor Author

aniruddha2000 commented Aug 27, 2021

Yes, Should I revert the changes and remove the symlink changes?

@pothos
Copy link
Copy Markdown
Contributor

pothos commented Aug 27, 2021

Yes, that would be the best if you don't want to fully replace bzip2 in this PR, thanks

@aniruddha2000
Copy link
Copy Markdown
Contributor Author

aniruddha2000 commented Aug 27, 2021

Yes we should wait for some time and then figure out in that time how we can remove the bzip2 properly.

pothos
pothos approved these changes Aug 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started a build and will merge when all tests finished

@aniruddha2000
Copy link
Copy Markdown
Contributor Author

aniruddha2000 commented Aug 27, 2021

@pothos Sure!

@pothos pothos merged commit c954e44 into flatcar-archive:main Aug 30, 2021
@pothos pothos mentioned this pull request Aug 30, 2021
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@pothos pothos pothos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aniruddha2000 @pothos