This repository was archived by the owner on May 30, 2023. It is now read-only.
docker/torcx: disable SELinux by default on dockerd wrapper script#1149
Merged
docker/torcx: disable SELinux by default on dockerd wrapper script#1149
dockerd wrapper script#1149Conversation
added 2 commits
July 30, 2021 10:33
it's the default behavior now. Since this script is deprecated, we do a minimum change on it. Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
this is now the default behavior - since this script is deprecated we do a minimum update on it Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
dongsupark
approved these changes
Jul 30, 2021
Contributor
Author
|
cherry-picked to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1055 we disabled
SELinuxfor Docker but we did not port this change to the deprecated scripts which enable by defaultSELinux.Testing done
We have a test for this
docker.lib-coreos-dockerd-compatbut we did not catch the failure because we explicitely set the--selinux-enabledto false - which overrides the default behavior ofdockerdscript. (see: flatcar/mantle@9101e70#diff-52b597358285b8b043950f2001c39f118a56284357fb13493292ad11d9aa224cR183)Closes: flatcar/Flatcar#457