This repository was archived by the owner on May 30, 2023. It is now read-only.
app-emulation/runc: remove patches disabling NNP and seccomp#1055
Merged
app-emulation/runc: remove patches disabling NNP and seccomp#1055
Conversation
These were included as a workaround for SELinux issues on Flatcar. However, they also disable NoNewPrivileges and seccomp support, which reduces security. Instead, we'll disable SELinux support in the Docker daemon in the next commit.
We disable SELinux because Flatcar doesn't properly support it and it was causing labeling problems when running runc containers with NoNewPrivileges or seccomp.
Contributor
|
I've triggered a CI build, will check the results tomorrow. http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/2807/ |
Contributor
sayanchowdhury
approved these changes
Jun 15, 2021
Contributor
|
Looks good, thanks! |
sayanchowdhury
added a commit
that referenced
this pull request
Jun 15, 2021
app-emulation/runc: remove patches disabling NNP and seccomp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were included as a workaround for SELinux issues on Flatcar.
However, they also disable NoNewPrivileges and seccomp support, which
reduces security.
Instead, we'll disable SELinux support in the Docker daemon in the next
commit.