Merged
Conversation
This is the only way I found to make it work.
We've never used travis for CI, github actions is all the rage these days.
This is much easier to handle from Flatcar's ebuilds.
The C implementation does not vendor correctly because C header files are present in the include/ subdirectory, and the go tool ignores them. This causes the build to fail. Update vmware/vmw-guestinfo so that we pick up a pure go based implementation.
and apply fixes.
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go fixes
go mod vendorandgo mod tidyHow to use
Testing done
changelog/directory (user-facing change, bug fix, security fix, update)