config/types/update.go Added support for more fields in update section#17
Merged
Merged
Conversation
Contributor
Author
|
Related to flatcar/Flatcar#453 |
jepio
reviewed
Feb 14, 2022
jepio
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for taking a look. The PCRPolicyServer setting is not wired to anything but we can keep it.
If you would adjust the typos in the docs, this can be merged directly.
89baa1f to
c87a863
Compare
Contributor
Author
If |
The following fields are now supported by the update section: * PCR_POLICY_SERVER * DOWNLOAD_USER * DOWNLOAD_PASSWORD * MACHINE_ALIAS also updated doc/configuration.md to reflect those changes. Signed-off-by: Michael Heinzner <michael.heinzner@googlemail.com>
c87a863 to
694b486
Compare
jepio
approved these changes
Feb 15, 2022
Member
|
Thanks! We should be able to tag a release in the near future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following fields are now supported by the update section:
also updated doc/configuration.md to reflect those changes.
Signed-off-by: Michael Heinzner michael.heinzner@googlemail.com
How to use
Execute
makeand execute the steps described inTesting doneTesting done
Transpile the following config.yaml
this was done with
./bin/ct <config.yaml | jq .and checked the output for all the necessary fields