This repository was archived by the owner on Jul 13, 2023. It is now read-only.
network: Encode information for systemd-networkd-wait-online#10
Merged
pothos merged 1 commit intoflatcar-masterfrom Oct 15, 2020
Merged
network: Encode information for systemd-networkd-wait-online#10pothos merged 1 commit intoflatcar-masterfrom
pothos merged 1 commit intoflatcar-masterfrom
Conversation
The network-online.target can use systemd-networkd-wait-online.service to wait for all interfaces to come up. It will fail if the interfaces didn't came up but sometimes it is actually ok for some interfaces to be down because they are unused or they are just one of two parts of a bond. We should encode when interfaces will never come up and when it is acceptable to have interfaces in a degraded state and which. Extend the network logic to handle this additional configuration. For Packet we expect the metadata to give all interfaces and any other physical NICs can be set to "unmanaged" so that we don't wait for them. We also allow bonds to operate with only one working link, and we don't wait for all bonded interfaces to be configured.
b3404d6 to
e2e89fc
Compare
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Oct 15, 2020
This pulls in flatcar-archive/afterburn#10 to fix systemd-networkd-wait-online on Equinix Metal (fka Packet).
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Oct 15, 2020
This pulls in flatcar-archive/afterburn#10 to fix systemd-networkd-wait-online on Equinix Metal (fka Packet).
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Oct 15, 2020
This pulls in flatcar-archive/afterburn#10 to fix systemd-networkd-wait-online on Equinix Metal (fka Packet).
pothos
added a commit
to pothos/afterburn
that referenced
this pull request
Mar 28, 2022
The network-online.target can use systemd-networkd-wait-online.service to wait for all interfaces to come up. It will fail if the interfaces didn't came up but sometimes it is actually ok for some interfaces to be down because they are unused or they are just one of two parts of a bond. We should encode when interfaces will never come up and when it is acceptable to have interfaces in a degraded state and which. Extend the network logic to handle this additional configuration. For Packet we expect the metadata to specify all interfaces, and any other physical NICs can be set to "unmanaged" so that we don't wait for them. Introduce "Path" matching in the networkd unit file for that. We also allow bonds to operate with only one working link, and we don't wait for all bonded interfaces to be configured. This is a port of flatcar-archive/afterburn#10 to afterburn's main branch.
pothos
added a commit
to pothos/afterburn
that referenced
this pull request
Apr 20, 2022
The network-online.target can use systemd-networkd-wait-online.service to wait for all interfaces to come up. It will fail if the interfaces didn't came up but sometimes it is actually ok for some interfaces to be down because they are unused or they are just one of two parts of a bond. We should encode when interfaces will never come up and when it is acceptable to have interfaces in a degraded state and which. Extend the network logic to handle this additional configuration. For Packet we expect the metadata to specify all interfaces, and any other physical NICs can be set to "unmanaged" so that we don't wait for them. Introduce "Path" matching in the networkd unit file for that. We also allow bonds to operate with only one working link, and we don't wait for all bonded interfaces to be configured. This is a port of flatcar-archive/afterburn#10 to afterburn's main branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The network-online.target can use systemd-networkd-wait-online.service
to wait for all interfaces to come up. It will fail if the interfaces
didn't came up but sometimes it is actually ok for some interfaces to
be down because they are unused or they are just one of two parts of a
bond. We should encode when interfaces will never come up and when it
is acceptable to have interfaces in a degraded state and which.
Extend the network logic to handle this additional configuration. For
Packet we expect the metadata to give all interfaces and any other
physical NICs can be set to "unmanaged" so that we don't wait for them.
We also allow bonds to operate with only one working link, and we don't
wait for all bonded interfaces to be configured.
Note: Also use this for
flatcar-2661Should be upstreamed.
How to use
Use with the new Flatcar Alpha build 2661 having systemd 246 on Equinix Metal (fka Packet) t1.small.x86 and c3.small.x86 instances and check that
/usr/lib/systemd/systemd-networkd-wait-onlinedoes not time out.Testing done
cargo testandcargo build, full test for the image done in flatcar-archive/coreos-overlay#648