-
Notifications
You must be signed in to change notification settings - Fork 49
docs(flatcar custom image): can't build custom image on fork #1705
Copy link
Copy link
Closed
Closed
Copy link
Labels
good first issueGet started with Flatcar contribution with this issue.Get started with Flatcar contribution with this issue.kind/docs
Description
$ ./run_sdk_container -t
fatal: No names found, cannot describe anything.
Reproduce
Here's the original: https://github.com/flatcar/scripts
Here's the fork: https://github.com/RiRa12621/scripts
Clone the fork: git clone https://github.com/RiRa12621/scripts.git
Move to dir: cd scripts
Set branch: branch="patch-1"
Run script:
$ ./run_sdk_container -t
fatal: No names found, cannot describe anything.
The issue is that there's a git describe --tags happening at https://github.com/flatcar/scripts/blob/main/sdk_lib/sdk_container_common.sh#L58 and that doesn't return anything.
Hypothetically, this can be mitigated via the following commands:
git remote add upstream https://github.com/flatcar/scripts.git
git fetch --tags upstream
However it's hard to find out if your on a fork without making a call got the GitHub API, hence I'm not sure if this is something that should be part of the script, or rather just the docs. Happy to contribute either of the two, once the best approach is decided.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGet started with Flatcar contribution with this issue.Get started with Flatcar contribution with this issue.kind/docs