update.conf with quoted MACHINE_ALIAS breaks update_engine #1209
Description
The Nebraska documentation gives the following example for /etc/flatcar/update.conf:
MACHINE_ALIAS="myhost a.b.c"
This results in the following request being logged in omaha_request_action.cc:
<?xml version="1.0" encoding="UTF-8"?>
<request protocol="3.0" version="update_engine-0.4.10" updaterversion="update_engine-0.4.10" installsource="ondemandupdate" ismachine="1">
<os version="Chateau" platform="CoreOS" sp="3732.1.0_x86_64"></os>
<app appid="{e96281a6-d1af-4bde-9a0a-97b76e56dc57}" version="3732.1.0" track="beta" bootid="{ef3c8c1c-5cee-4f03-87db-13903ab7f866}" oem="vmware" oemversion="11.1.5" alephversion="2135.6.0" machineid="06fe98d2a89248b6a2542ef2bcb8c16a" machinealias=""myhost a.b.c"" lang="en-US" board="amd64-usr" hardware_class="" delta_okay="false" >
<ping active="1"></ping>
<updatecheck></updatecheck>
<event eventtype="3" eventresult="2" previousversion=""></event>
</app>
</request>Note the invalid XML due to duplicate quotes:
machinealias=""myhost a.b.c""
When setting MACHINE_ALIAS without quotes the update process works, even though the documentation implies that quotes are required when using whitespace. Doing so breaks motdgen.service instead, however.
Observed in 3602.2.0 stable and 3732.1.0 beta