ci: upgrade apache-tvm-ffi version in ci containers#1788
ci: upgrade apache-tvm-ffi version in ci containers#1788yzh119 merged 1 commit intoflashinfer-ai:mainfrom
Conversation
Summary of ChangesHello @yzh119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the stability of the continuous integration pipeline by updating a critical dependency. The change ensures that the build process can proceed without encountering known errors related to an outdated package version, thereby maintaining a reliable development environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the apache-tvm-ffi package version in the CI container installation script, pinning it to 0.1.0b8. This is a good change that improves the reproducibility of the CI environment. I have added one suggestion to consider moving all Python dependencies to a requirements.txt file to further enhance maintainability and ensure all dependencies are pinned, which is a best practice for CI environments.
| pip3 install torch --index-url https://download.pytorch.org/whl/${CUDA_VERSION} | ||
| pip3 install requests ninja pytest numpy scipy build nvidia-ml-py cuda-python einops nvidia-nvshmem-cu12 | ||
| pip3 install 'apache-tvm-ffi>=0.1.0b6' | ||
| pip3 install 'apache-tvm-ffi==0.1.0b8' |
There was a problem hiding this comment.
Pinning the apache-tvm-ffi version is a great step for ensuring reproducible builds. To improve maintainability and consistency across all dependencies, consider moving all Python packages into a requirements.txt file. This centralizes dependency management, makes it clear which versions are used, and prevents potential issues from unpinned packages in the future. You could then replace the multiple pip3 install calls with a single pip3 install -r path/to/requirements.txt.
📌 Description
Incorporate changes in apache/tvm-ffi@eb5492a to fix the CI errors in https://ci.tlcpack.ai/blue/organizations/jenkins/flashinfer-ci/detail/PR-1641/95/pipeline
🔍 Related Issues
#1641
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes
cc @nvmbreughe @cyx-6 @tqchen