Skip to content

feat: update and test create_ipc_buffer#1130

Merged
yyihuang merged 5 commits intoflashinfer-ai:mainfrom
yyihuang:update_ipc
Jun 9, 2025
Merged

feat: update and test create_ipc_buffer#1130
yyihuang merged 5 commits intoflashinfer-ai:mainfrom
yyihuang:update_ipc

Conversation

@yyihuang
Copy link
Copy Markdown
Collaborator

@yyihuang yyihuang commented Jun 9, 2025

📌 Description

Update the create_ipc_buffer implementation. Add unit tests for create_ipc_buffer.

🔍 Related Issues

To help debug #1108.

🚀 Pull Request Checklist

Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.

✅ Pre-commit Checks

  • I have installed pre-commit by running pip install pre-commit (or used your preferred method).
  • I have installed the hooks with pre-commit install.
  • I have run the hooks manually with pre-commit run --all-files and fixed any reported issues.

If you are unsure about how to set up pre-commit, see the pre-commit documentation.

🧪 Tests

  • Tests have been added or updated as needed.
  • All tests are passing (unittest, etc.).

Reviewer Notes

@yyihuang yyihuang requested a review from yzh119 June 9, 2025 03:37
@yyihuang yyihuang changed the title Add unit test for create_ipc_buffer feat: update create_ipc_buffer and test Jun 9, 2025
@yyihuang yyihuang changed the title feat: update create_ipc_buffer and test feat: update and test create_ipc_buffer Jun 9, 2025
Comment thread flashinfer/comm.py
Comment thread flashinfer/comm.py Outdated
Comment thread tests/test_create_ipc_buffer.py Outdated
Copy link
Copy Markdown
Collaborator

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@yyihuang yyihuang merged commit a023006 into flashinfer-ai:main Jun 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants