SM100 Groupwise GeMM K-Major Scale Supports#1102
Merged
yzh119 merged 2 commits intoflashinfer-ai:mainfrom May 31, 2025
Merged
Conversation
yzh119
reviewed
May 30, 2025
| The granularity of the scale tensor, (m_granularity, n_granularity, k_granularity). | ||
|
|
||
| scale_major_k: bool | ||
| Whether scale tensors are k-major layout. |
Collaborator
There was a problem hiding this comment.
better to explain what's k-major (and the alternative mn-major) because it can be confusing to new users.
The name scale_major_k is also confusing, can we usescale_major_mode: str = "MN" or "K" instead?
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
🔍 Related Issues
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit(or used your preferred method).pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
unittest, etc.).Reviewer Notes