Add useGrimAdapter option to the config window#3943
Add useGrimAdapter option to the config window#3943borgmanJeremy merged 3 commits intoflameshot-org:masterfrom
Conversation
|
I just came to know that |
|
The following is the copy of my comment on the code:
Also, should this only be displayed in Wayland? |
|
This option is for wayland users, right? It should not be shown in X11. |
|
For the name/description
??? |
|
Maybe based on the description here: https://gitlab.freedesktop.org/emersion/grim/-/blob/master/doc/grim.1.scd?ref_type=heads it can say something like |
borgmanJeremy
left a comment
There was a problem hiding this comment.
Approved and will merge as is. But if you want to adjust the wording based on the conversation I'll wait a day or so. Else I can edit the text later.
|
Okay I will push the edit |
|
|
src/config/generalconf.cpp
Outdated
| void GeneralConf::initUseGrimAdapter() | ||
| { | ||
| #if defined(Q_OS_LINUX) | ||
| m_useGrimAdapter = new QCheckBox(tr("Use grim adapter"), this); |
There was a problem hiding this comment.
I think we need to come up with a better text here. I think for the general user, this is cryptic. Unfortunately I don't have a suggestion though [yet] 😅
What do you think?
As stated in this issue, #3919 added an option to use grim adapter, but it was not added to the config UI window.
This PR adds this option (
useGrimAdapter) to the config UI.Option name:
Use grim to capture screenshotsDescription:
Grim is a wayland only utility to capture screens based on the screencopy protocol. Generally only enable on minimal wayland window managers like sway, hyprland, etc.Tested, works!
EDIT: old screenshot, see comments below
(PS: screenshot taken with flameshot)
Closes #3941