Conversation
devinamatthews
left a comment
There was a problem hiding this comment.
For tests that require SDE, perhaps we should cut the tests back to:
- gemm, trsm, and gemmtrsm ukernels (including all storage types)
- Ideally, packing ukernels in isolation but a small gemm should suffice.
- Unaligned C, could be combined with 1) and/or 2).
- The above for all datatypes, including 1m but not 3m/4m.
|
Also note that the travis_driver.sh script checks /proc/cpuinfo which won't work on OSX. |
|
I properly guarded access to I will fix this. |
|
How about these test input files (for tests that run with SDE)? |
|
@devinamatthews Thanks. I'll incorporate them shortly. |
- it is hard to do all the branching required for this in the .travis.yml so we drop into travis_driver.sh and handle everything. - detect hardware and run tests natively when possible - only use -d sde for KNL (requires merge w/ not-real-knl branch) - add SDE download+install - compile tests outside of SDE - support 32-bit Travis (unlikely?)
fe17b5f to
b669f57
Compare
|
@jeffhammond can you elaborate on |
|
There are likely better methods. I'm happy to accept suggestions. |
|
Now that I think of it, I can make the link public if I password-protect the file and then hide the password in a Travis secure env var, but I have a bad experience with that in the context of doing that with Intel compiler license keys when trying to support Intel compilers in Travis. |
|
This has been implemented in the |
|
What about using MUSL instead of GLIBC? MUSL may not have all the CPU-specific optimizations and therefore behave better. |
|
I've got a workaround in place, now I just have to deal with the kernel security flags so that sde will run. |
|
Closing in favor of #212, which incorporates all of the contributions here. Thanks @jeffhammond for the idea and the crucial details. |
This pull request implements #122.
This overhauls most of the Travis CI stuff. In particular:
BUILD_CONFIG=auto.As noted by @devinamatthews, performance with SDE is ~0.02 GF/s, so we probably need to prune the tests if we want them to finish in under an hour.