Merged
Conversation
Closed
fitzgen
reviewed
Oct 3, 2024
Comment on lines
+31
to
+34
| - name: Install `cargo wasi` | ||
| run: cargo install cargo-wasi | ||
| - name: Install `wasmtime` | ||
| run: curl https://wasmtime.dev/install.sh -sSf | bash |
Owner
There was a problem hiding this comment.
CI seems to be failing. Could you also move this out into a new, dedicated job, instead of making every matrix job run the wasm tests?
Contributor
Author
There was a problem hiding this comment.
oh.
addition source ~/.bashrc.
cargo-wasi bin support only linux.
Contributor
Author
|
I updated commit |
Owner
|
Hmm looks like CI is still failing. I think that |
Contributor
Author
|
oh, thanks. and I forget to rm test on matrix |
Contributor
Author
|
Sorry. I accidentally closed it once by mistake, I've checked the operation using act, so it should be fine. |
fitzgen
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.