Skip to content

Fix bugs uncovered by AFL#41

Merged
fitzgen merged 3 commits intomasterfrom
fix-afl-bugs
Feb 3, 2017
Merged

Fix bugs uncovered by AFL#41
fitzgen merged 3 commits intomasterfrom
fix-afl-bugs

Conversation

@fitzgen
Copy link
Member

@fitzgen fitzgen commented Feb 3, 2017

Fixes #39

This fixes an issue discovered by AFL.rs, where we eagerly unwrap the result of
`isize::from_str_radix` because we checked that the string contains only valid
digits. However, we did not check that the string of digits form a number within
the range of `isize`, and potentially try to parse a number larger than
`isize::MAX`. This resulted in an `Err` return value, and a panic when we unwrap
it.
@coveralls
Copy link

Coverage Status

Coverage increased (+1.7%) to 94.995% when pulling 9ba5c2d on fix-afl-bugs into 64afc30 on master.

@fitzgen fitzgen merged commit c77592a into master Feb 3, 2017
@fitzgen fitzgen deleted the fix-afl-bugs branch February 14, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants