fix(crash): Update parry2d to 0.13.7 (use rapier fork) for crash fix in QBVH#960
Merged
MaxCWhitehead merged 1 commit intofishfolk:mainfrom Apr 6, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been frequently hitting a crash / bug in parry2d QBVH involving incremental update. Sometimes it crashes, sometimes is a framerate death spiral / fully locks up.
Appears to be been fixed at dimforge/parry@7df2728 in parry2d 0.13.7. Updated rapier to use a fork with parry2d update as not updated in rapier yet.