Merged
Conversation
Member
That could also make it a good candidate for a Lua implementation. This PR is good as-is, just putting a note in for later. |
Collaborator
|
Awesome! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Periscope ported, this closes #151.
It's similar to the musket and is mainly useful if the enemy is higher than you. Used the artwork from #151 but the concept art confused me a bit as it says to be "similar to the musket" but in the art it looks like more a shotgun as it has some bullet spread, but adding a very low bullet spread would be a nice idea here so let me know if you think it should be used.
As it's very similar to the musket, it had a certain amount of code duplication, which I think we could discuss together and come to a decision whether to generalize something elsewhere or whether we want to make adjustments to add more uniqueness to the designs.