Skip to content

fix: sliding collisions#911

Merged
zicklag merged 2 commits intofishfolk:mainfrom
nelson137:fix/sliding-collision
Jan 25, 2024
Merged

fix: sliding collisions#911
zicklag merged 2 commits intofishfolk:mainfrom
nelson137:fix/sliding-collision

Conversation

@nelson137
Copy link
Contributor

Closes #910

This was more simple than I expected. When a sliding player collides with something and stops moving, the transform adjustment to stand up didn't take into account the direction the player is facing.

fixed-collisions.mp4

@nelson137
Copy link
Contributor Author

This advisory check task will pass once #909 is merged and I rebase

@zicklag
Copy link
Member

zicklag commented Jan 24, 2024

Oh, sweet! That's so nice to have fixed. It's one of those small wrinkles that has bugged me since I ported the original physics. :)

@zicklag zicklag added this pull request to the merge queue Jan 25, 2024
Merged via the queue into fishfolk:main with commit 3e99ea2 Jan 25, 2024
@nelson137 nelson137 deleted the fix/sliding-collision branch January 25, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: incorrect collision when player slides into the right side of a solid

2 participants